search

arduino-libraries / ArduinoGraphics

35 stars 21 forks source link

Made TextColor independent of Stroke #15

Closed ashutoshshrm529 closed 2 months ago

ashutoshshrm529 commented 4 years ago

A solution for #5

Here I have tried to make text color completely independent of stroke color. I have also added another clone bitmap function ( text_bitmap ) which uses the text color instead of stroke. I preserved the original bitmap function since I was not sure about its uses elsewhere. Now the text color can be set using both the setTextColor function or the BeginText functions with color inputs.

Please review and suggest changes as you may see fit.

CLAassistant commented 3 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

leonardocavagnis commented 2 months ago

Since this library is based on the Processing API, and according to the Processing text() documentation, the font color should indeed be changed using the fill() function.

This PR is being closed due to inconsistency with the Processing API.