Update HttpClient.h - Githubissues

arduino-libraries / ArduinoHttpClient

Arduino HTTP Client library

282 stars 170 forks source link

Update HttpClient.h #63

Closed Warlib1975 closed 5 years ago

Warlib1975 commented 5 years ago

In ESP32/ESP8266 in Client there are two additional abstract methods exists: virtual int connect(IPAddress ip, uint16_t port, int timeout) =0; virtual int connect(const char *host, uint16_t port, int timeout) =0; They are not implemented in HttpClient.h, so compilations stops with error.

sandeepmistry commented 5 years ago

Let's see how the discussion in https://github.com/arduino-libraries/Ethernet/pull/95/files#r277642823 goes before merging this. cc/ @per1234

per1234 commented 5 years ago

Fixed for ESP32 espressif/arduino-esp32#3191

I checked the entire history of Client.h in the ESP8266 core and it never had these overloads of Client.connect().