arduino-libraries / ArduinoHttpClient

Arduino HTTP Client library
282 stars 170 forks source link

Add ESP32/ESP8266 support in HttpClient.h #64

Closed Warlib1975 closed 5 years ago

Warlib1975 commented 5 years ago

In ESP32/ESP8266 in Client there are two additional abstract methods exists: virtual int connect(IPAddress ip, uint16_t port, int timeout) =0; virtual int connect(const char *host, uint16_t port, int timeout) =0; They are not implemented in HttpClient.h, so compilations stops with error.

per1234 commented 5 years ago

This is a duplicate of https://github.com/arduino-libraries/ArduinoHttpClient/pull/63, except this one has the wrong file name (TinyGsmClientSIM800.h) in the error messages.

Warlib1975 commented 5 years ago

Yes, in this update I just change the wrong filename of the *.h file.

sandeepmistry commented 5 years ago

Closing in favour of https://github.com/arduino-libraries/ArduinoHttpClient/pull/63 for now.