search

arduino-libraries / ArduinoHttpClient

Arduino HTTP Client library
288 stars 172 forks source link

Basic authentication for web socket #77

Open biohazardious opened 5 years ago

biohazardious commented 5 years ago

I added basic authentication for web socket.

biohazardious commented 4 years ago

Hi @sandeepmistry ,

I added new begin signatures because unlike HttpClient REST methods, you should send authentication data while creating socket. That's why i modified begin function.

PS: sorry for whitespaces, it was a quick fix those was my mistake.

sandeepmistry commented 4 years ago

Hi @biohazardious,

Ok, got it so sendBasicAuth is not the best name. An alternative is what we have in the MQTT Cient library: https://github.com/arduino-libraries/ArduinoMqttClient/blob/master/src/MqttClient.h#L85

setUsernamePassword or setBasicAuth - this is something you would call before begin.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.