search

arduino-libraries / ArduinoHttpClient

Arduino HTTP Client library
282 stars 170 forks source link

Using ServerAddress for Host header #83

Open lehecka opened 4 years ago

lehecka commented 4 years ago

The HttpClient can be initialized with a ServerName(string) or ServerAddress (IPAddress). In the first case the underlaying Client will use DNS lookup to translate the name to the IP address. This lookup code is consuming extra bytes in memory. When making the HTTP request the ServerName is used for Host header. If the ServerAddress is specified in the ctor of the HttpClient then the HTTP requests are missing the Host header.

In this diff the user has ability to call useServerAddressForHostHeader to use the ServerAddress for the Host header.

As a workaround without this fix one has to use sendHeader / beginBody / endRequest call which makes the API use very cumbersome and error prone .

CLAassistant commented 3 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.