Service query is overflowing

arduino-libraries / ArduinoMDNS

mDNS Library for Arduino

40 stars 13 forks source link

Service query is overflowing #8

Open Luftzig opened 4 years ago

Luftzig commented 4 years ago

by sending the length the header instead of the just 4 needed bytes. See #7

CLAassistant commented 3 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Yoav Luft seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

gigaj0ule commented 2 years ago

This PR fixes a critical bug!

Without it we get weird buffer overruns in the processing logic that cause malformed packets.

@agdl, @marqdevx, does this library have any maintainers?

If not you can add me as one and I will upstream this as well as try to merge the sensible future commits from trippylightning's branch.

zyphlar commented 7 months ago

Removing a call to addServiceRecord made this library way more reliable for me @aentinger