arduino-libraries / ArduinoMqttClient

ArduinoMqttClient Library for Arduino
GNU Lesser General Public License v2.1
186 stars 73 forks source link

`-Wvla` compiler warnings #109

Open zfields opened 1 month ago

zfields commented 1 month ago
~/Development/Arduino/libraries/ArduinoMqttClient/src/MqttClient.cpp: In member function 'int MqttClient::subscribe(const char*, uint8_t)':
~/Development/Arduino/libraries/ArduinoMqttClient/src/MqttClient.cpp:333:43: warning: variable length array 'packetBuffer' is used [-Wvla]
   uint8_t packetBuffer[5 + remainingLength];
                                           ^
~/Development/Arduino/libraries/ArduinoMqttClient/src/MqttClient.cpp: In member function 'int MqttClient::unsubscribe(const char*)':
~/Development/Arduino/libraries/ArduinoMqttClient/src/MqttClient.cpp:381:43: warning: variable length array 'packetBuffer' is used [-Wvla]
   uint8_t packetBuffer[5 + remainingLength];
                                           ^
~/Development/Arduino/libraries/ArduinoMqttClient/src/MqttClient.cpp: In member function 'int MqttClient::connect(arduino::IPAddress, const char*, uint16_t)':
~/Development/Arduino/libraries/ArduinoMqttClient/src/MqttClient.cpp:910:43: warning: variable length array 'packetBuffer' is used [-Wvla]
   uint8_t packetBuffer[5 + remainingLength];
                                           ^
~/Development/Arduino/libraries/ArduinoMqttClient/src/MqttClient.cpp: In member function 'int MqttClient::publishHeader(size_t)':
~/Development/Arduino/libraries/ArduinoMqttClient/src/MqttClient.cpp:982:46: warning: variable length array 'packetHeaderBuffer' is used [-Wvla]
   uint8_t packetHeaderBuffer[5 + headerLength];
                                              ^
zfields commented 1 month ago

arduino-cli compile --verbose --warnings=all --build-property "build.extra_flags=-Wno-unused-variable -Wno-implicit-fallthrough -Wno-psabi -Wno-deprecated-copy -Wno-missing-field-initializers -Wno-delete-non-virtual-dtor -Wno-sign-compare -Og -g" --fqbn arduino:mbed_opta:opta <dev folder>