Closed sandeepmistry closed 4 years ago
the invalid pure virtual functions were only in esp8266 core 2.5.0. they were reverted in 2.5.1 in May, current version of esp8266 core is 2.6.1
@jandrassy is there some way to determine the core version at compile time?
@jandrassy is there some way to determine the core version at compile time?
why is the compatibility with broken 2.5.0 important?
why is the compatibility with broken 2.5.0 important?
@jandrassy I'm not sure, there is only a comment from @lxrobotics: https://github.com/arduino-libraries/ArduinoMqttClient/commit/ade2940a2ffe1cdc04e39d638d28378cc2c41c32#commitcomment-35808711 that Create needs it.
@lxrobotics and/or @eclipse1985 could you please explain?
We have to keep the compatibility with 2.5.0 because on create we are locked at this version. Versions >2.5 have totally changed the build/upload tools, and we are unable to port them on create agent right now.
We have to keep the compatibility with 2.5.0 because on create we are locked at this version. Versions >2.5 have totally changed the build/upload tools, and we are unable to port them on create agent right now.
esp8266 core 2.4.2 is a very good version. 2.5.0 updated to Espressif SDK 3.0 beta and it doesn't work good. they reverted to SDK 2.2.x in 2.5.1
@jandrassy Thank you for letting us know. I suppose the virtual function declarations causing this change are still defined in ESP8266 Core 2.4.2 Client
class?
@jandrassy Thank you for letting us know. I suppose the virtual function declarations causing this change are still defined in ESP8266 Core 2.4.2
Client
class?
they are not. Only 2.5.0 is wrong.
@eclipse1985 How about downgrading to 2.4.2
then?
I'm not sure this is feasible on create side cc @rsora @matteosuppo
Based on the discussions in:
@lxrobotics for @jandrassy's concerns, to reproduce, use the WiFiEcho.ino and change:
to
You will get a compile error.