search

arduino-libraries / ArduinoMqttClient

ArduinoMqttClient Library for Arduino
GNU Lesser General Public License v2.1
187 stars 73 forks source link

Removing default value assignment within connect function #31

Closed aentinger closed 4 years ago

aentinger commented 4 years ago

This change is catching two things at once ... 1) we don't have the ugly function to stay complian to ESP8266 core 2.5.0 and 2) we don't have overload function resolving problems when actually using connect with an IPAddress argument (as is done here). Drawback: This will break all sketches which have relied on the default parameter being set. (Note for the future: Default parameters are really dangerous).

aentinger commented 4 years ago

Closing this because the great @facchinm initiated a upgrade to the latest ESP8266 core within for Arduino Create.