arduino-libraries / ArduinoMqttClient

ArduinoMqttClient Library for Arduino
GNU Lesser General Public License v2.1
192 stars 75 forks source link

Possibility to change tx_payload_buffer_size #44

Closed Kacp3r3 closed 3 years ago

Kacp3r3 commented 4 years ago

Maximum size of the tx paylod buffer was fixed value, there should be possibility to extend this value by user, so i added a new member variable with according setter function.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

JDuchniewicz commented 3 years ago

This gave me a headache, and I had to change the define manually because Arduino uses old version of this library.

krzysztofkrzeslak commented 3 years ago

This gave me a headache, and I had to change the define manually because Arduino uses old version of this library.

@aentinger maybe it's time to consider merging it, as it seems like a bug and I think we were not the only one who came across this issue. At least it should be mentioned somewhere that if long MQTT messages are cut/truncated then you should check the value of this definition, as this is behavior that is being observed in effect. Thanks!

aentinger commented 3 years ago

I will merge this, if @Kacp3r3 drops 33314086e4501d24f91e1202df91bf3ccb6249af from this patch.

Kacp3r3 commented 3 years ago

As you wish

github-actions[bot] commented 3 years ago

Memory usage change @ 79f512ff77b32767c267c98cb304d04e452fe167

Board flash % RAM for global variables %
arduino:megaavr:uno2018 :small_red_triangle: +8 - +8 +0.02 - +0.02 :small_red_triangle: +2 - +2 +0.03 - +0.03
arduino:samd:mkr1000 :small_red_triangle: +8 - +8 0.0 - 0.0 :small_red_triangle: +4 - +4 +0.01 - +0.01
arduino:samd:mkrwifi1010 :small_red_triangle: 0 - +8 0.0 - 0.0 :small_red_triangle: +4 - +4 +0.01 - +0.01
arduino:samd:nano_33_iot :small_red_triangle: +8 - +8 0.0 - 0.0 :small_red_triangle: +4 - +4 +0.01 - +0.01
Click for full report table Board|examples/WiFiAdvancedCallback
flash|%|examples/WiFiAdvancedCallback
RAM for global variables|%|examples/WiFiEcho
flash|%|examples/WiFiEcho
RAM for global variables|%|examples/WiFiEchoCallback
flash|%|examples/WiFiEchoCallback
RAM for global variables|%|examples/WiFiSimpleReceive
flash|%|examples/WiFiSimpleReceive
RAM for global variables|%|examples/WiFiSimpleReceiveCallback
flash|%|examples/WiFiSimpleReceiveCallback
RAM for global variables|%|examples/WiFiSimpleSender
flash|%|examples/WiFiSimpleSender
RAM for global variables|% -|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|- arduino:megaavr:uno2018|8|0.02|2|0.03|8|0.02|2|0.03|8|0.02|2|0.03|8|0.02|2|0.03|8|0.02|2|0.03|8|0.02|2|0.03 arduino:samd:mkr1000|8|0.0|4|0.01|8|0.0|4|0.01|8|0.0|4|0.01|8|0.0|4|0.01|8|0.0|4|0.01|8|0.0|4|0.01 arduino:samd:mkrwifi1010|0|0.0|4|0.01|8|0.0|4|0.01|8|0.0|4|0.01|0|0.0|4|0.01|0|0.0|4|0.01|8|0.0|4|0.01 arduino:samd:nano_33_iot|8|0.0|4|0.01|8|0.0|4|0.01|8|0.0|4|0.01|8|0.0|4|0.01|8|0.0|4|0.01|8|0.0|4|0.01
Click for full report CSV ``` Board,examples/WiFiAdvancedCallback
flash,%,examples/WiFiAdvancedCallback
RAM for global variables,%,examples/WiFiEcho
flash,%,examples/WiFiEcho
RAM for global variables,%,examples/WiFiEchoCallback
flash,%,examples/WiFiEchoCallback
RAM for global variables,%,examples/WiFiSimpleReceive
flash,%,examples/WiFiSimpleReceive
RAM for global variables,%,examples/WiFiSimpleReceiveCallback
flash,%,examples/WiFiSimpleReceiveCallback
RAM for global variables,%,examples/WiFiSimpleSender
flash,%,examples/WiFiSimpleSender
RAM for global variables,% arduino:megaavr:uno2018,8,0.02,2,0.03,8,0.02,2,0.03,8,0.02,2,0.03,8,0.02,2,0.03,8,0.02,2,0.03,8,0.02,2,0.03 arduino:samd:mkr1000,8,0.0,4,0.01,8,0.0,4,0.01,8,0.0,4,0.01,8,0.0,4,0.01,8,0.0,4,0.01,8,0.0,4,0.01 arduino:samd:mkrwifi1010,0,0.0,4,0.01,8,0.0,4,0.01,8,0.0,4,0.01,0,0.0,4,0.01,0,0.0,4,0.01,8,0.0,4,0.01 arduino:samd:nano_33_iot,8,0.0,4,0.01,8,0.0,4,0.01,8,0.0,4,0.01,8,0.0,4,0.01,8,0.0,4,0.01,8,0.0,4,0.01 ```