arduino-libraries / ArduinoMqttClient

ArduinoMqttClient Library for Arduino
GNU Lesser General Public License v2.1
186 stars 73 forks source link

initializer order wrong of _tx_payload_buffer_size - causes compile error #60

Closed tbaust closed 2 years ago

tbaust commented 2 years ago

Just the order needs to be changed to get rid of the reorder error (warning enabled as error)

.pio\libdeps\esp32dev\ArduinoMqttClient\src\MqttClient.h:184:11: error: 'MqttClient::_willFlags' will be initialized after [-Werror=reorder] uint8_t _willFlags; ^ .pio\libdeps\esp32dev\ArduinoMqttClient\src\MqttClient.h:146:18: error: 'short unsigned int MqttClient::_tx_payload_buffer_size' [-Werror=reorder] unsigned short _tx_payload_buffer_size;

CLAassistant commented 2 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: tbaust
:x: Thomas Baust


Thomas Baust seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

github-actions[bot] commented 2 years ago

Memory usage change @ 118b0f16a0929c02bd550af0397f4b0a73a18605

Board flash % RAM for global variables %
arduino:megaavr:uno2018 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table Board|examples/WiFiAdvancedCallback
flash|%|examples/WiFiAdvancedCallback
RAM for global variables|%|examples/WiFiEcho
flash|%|examples/WiFiEcho
RAM for global variables|%|examples/WiFiEchoCallback
flash|%|examples/WiFiEchoCallback
RAM for global variables|%|examples/WiFiSimpleReceive
flash|%|examples/WiFiSimpleReceive
RAM for global variables|%|examples/WiFiSimpleReceiveCallback
flash|%|examples/WiFiSimpleReceiveCallback
RAM for global variables|%|examples/WiFiSimpleSender
flash|%|examples/WiFiSimpleSender
RAM for global variables|% -|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|- arduino:megaavr:uno2018|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0 arduino:samd:mkr1000|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0 arduino:samd:mkrwifi1010|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0 arduino:samd:nano_33_iot|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0
Click for full report CSV ``` Board,examples/WiFiAdvancedCallback
flash,%,examples/WiFiAdvancedCallback
RAM for global variables,%,examples/WiFiEcho
flash,%,examples/WiFiEcho
RAM for global variables,%,examples/WiFiEchoCallback
flash,%,examples/WiFiEchoCallback
RAM for global variables,%,examples/WiFiSimpleReceive
flash,%,examples/WiFiSimpleReceive
RAM for global variables,%,examples/WiFiSimpleReceiveCallback
flash,%,examples/WiFiSimpleReceiveCallback
RAM for global variables,%,examples/WiFiSimpleSender
flash,%,examples/WiFiSimpleSender
RAM for global variables,% arduino:megaavr:uno2018,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0 arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0 arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0 arduino:samd:nano_33_iot,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0 ```
github-actions[bot] commented 2 years ago

Memory usage change @ d76cbe57fb3e863874bb983f962306b5f5f78c5e

Board flash % RAM for global variables %
arduino:megaavr:uno2018 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table Board|examples/WiFiAdvancedCallback
flash|%|examples/WiFiAdvancedCallback
RAM for global variables|%|examples/WiFiEcho
flash|%|examples/WiFiEcho
RAM for global variables|%|examples/WiFiEchoCallback
flash|%|examples/WiFiEchoCallback
RAM for global variables|%|examples/WiFiSimpleReceive
flash|%|examples/WiFiSimpleReceive
RAM for global variables|%|examples/WiFiSimpleReceiveCallback
flash|%|examples/WiFiSimpleReceiveCallback
RAM for global variables|%|examples/WiFiSimpleSender
flash|%|examples/WiFiSimpleSender
RAM for global variables|% -|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|- arduino:megaavr:uno2018|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0 arduino:samd:mkr1000|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0 arduino:samd:mkrwifi1010|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0 arduino:samd:nano_33_iot|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0
Click for full report CSV ``` Board,examples/WiFiAdvancedCallback
flash,%,examples/WiFiAdvancedCallback
RAM for global variables,%,examples/WiFiEcho
flash,%,examples/WiFiEcho
RAM for global variables,%,examples/WiFiEchoCallback
flash,%,examples/WiFiEchoCallback
RAM for global variables,%,examples/WiFiSimpleReceive
flash,%,examples/WiFiSimpleReceive
RAM for global variables,%,examples/WiFiSimpleReceiveCallback
flash,%,examples/WiFiSimpleReceiveCallback
RAM for global variables,%,examples/WiFiSimpleSender
flash,%,examples/WiFiSimpleSender
RAM for global variables,% arduino:megaavr:uno2018,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0 arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0 arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0 arduino:samd:nano_33_iot,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0 ```