search

arduino-libraries / ArduinoMqttClient

ArduinoMqttClient Library for Arduino
GNU Lesser General Public License v2.1
186 stars 73 forks source link

Fix gcc reorder warning #72

Closed pennam closed 2 years ago

pennam commented 2 years ago

This will satisfy gcc complaining about reordering the initializer list.

NOTE: The last ESP32 core is enforcing-Wall -Werror=all compiler flags using https://github.com/espressif/arduino-esp32/blob/2.0.4/platform.txt#L105-L110 so a wrong initialization order will cause a build error.

github-actions[bot] commented 2 years ago

Memory usage change @ 0fe67a4e00c1321ab016d836bf401e698744c6be

Board flash % RAM for global variables %
arduino:megaavr:uno2018 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table Board|examples/WiFiAdvancedCallback
flash|%|examples/WiFiAdvancedCallback
RAM for global variables|%|examples/WiFiEcho
flash|%|examples/WiFiEcho
RAM for global variables|%|examples/WiFiEchoCallback
flash|%|examples/WiFiEchoCallback
RAM for global variables|%|examples/WiFiSimpleReceive
flash|%|examples/WiFiSimpleReceive
RAM for global variables|%|examples/WiFiSimpleReceiveCallback
flash|%|examples/WiFiSimpleReceiveCallback
RAM for global variables|%|examples/WiFiSimpleSender
flash|%|examples/WiFiSimpleSender
RAM for global variables|% -|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|- arduino:megaavr:uno2018|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0 arduino:samd:mkr1000|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0 arduino:samd:mkrwifi1010|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0 arduino:samd:nano_33_iot|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0
Click for full report CSV ``` Board,examples/WiFiAdvancedCallback
flash,%,examples/WiFiAdvancedCallback
RAM for global variables,%,examples/WiFiEcho
flash,%,examples/WiFiEcho
RAM for global variables,%,examples/WiFiEchoCallback
flash,%,examples/WiFiEchoCallback
RAM for global variables,%,examples/WiFiSimpleReceive
flash,%,examples/WiFiSimpleReceive
RAM for global variables,%,examples/WiFiSimpleReceiveCallback
flash,%,examples/WiFiSimpleReceiveCallback
RAM for global variables,%,examples/WiFiSimpleSender
flash,%,examples/WiFiSimpleSender
RAM for global variables,% arduino:megaavr:uno2018,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0 arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0 arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0 arduino:samd:nano_33_iot,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0 ```
aentinger commented 2 years ago

The last ESP32 core is enforcing-Wall -Werror=all compiler flags

Do they now? Very laudable :clap:

pennam commented 2 years ago

I think yes, -Werror=all is enabled only for higher warning levels: more and all

https://github.com/espressif/arduino-esp32/blob/2.0.4/platform.txt#L105-L110