Giga R1 WiFi works with a small change

arduino-libraries / ArduinoMqttClient

ArduinoMqttClient Library for Arduino

GNU Lesser General Public License v2.1

186 stars 73 forks source link

Giga R1 WiFi works with a small change #85

Closed esp32beans closed 1 year ago

esp32beans commented 1 year ago

I tested ver 0.1.6 using Giga R1 WiFi. Only a small change is required to make the examples work. I removed the check for ESP32 because Giga also uses WiFi.h.

Old

#elif defined(ESP32)
  #include <WiFi.h>
#endif

New

#else
  #include <WiFi.h>
#endif

Is it too much to hope new boards will implement the standard Arduino WiFi API? For example, Uno R4 will have a WiFi option. Would be nice to avoid releasing a new version of the library whenever a new board with WiFi appears.

aentinger commented 1 year ago

I've fixed this library.

It would probably pay off to do a new release of this library, any objections @pennam ?

pennam commented 1 year ago

Not at all. Thanks @aentinger :+1:

aentinger commented 1 year ago

Done https://github.com/arduino-libraries/ArduinoMqttClient/releases/tag/0.1.7 :wink: :bow: