search

arduino-libraries / Arduino_ConnectionHandler

GNU General Public License v3.0
97 stars 36 forks source link

Bugfix: Don't break MKRGSM stack when ping fails. #36

Closed aentinger closed 4 years ago

aentinger commented 4 years ago

Calling attachGPRS multiple times is not handled well by the MRK GSM/MKR GSM stack. But this is exactly what happens when the first call to ping fails. Consequently the attachGPRS part has been moved one state up so it will be only called once.

github-actions[bot] commented 4 years ago

Memory usage change @ 21825b4ffe3ccaa553198dc204b61bf92ddd6a87

Board flash RAM for global variables
arduino:samd:mkr1000 0 - 0 0 - 0
arduino:samd:mkrgsm1400 :green_heart: -8 - -8 0 - 0
arduino:samd:mkrnb1500 0 - 0 0 - 0
arduino:samd:mkrwan1300 0 - 0 0 - 0
arduino:samd:mkrwan1310 0 - 0 0 - 0
arduino:samd:mkrwifi1010 0 - 0 0 - 0
arduino:samd:nano_33_iot 0 - 0 0 - 0
esp8266:esp8266:huzzah 0 - 0 0 - 0
Click for full report table Board|examples/ConnectionHandlerDemo
flash|examples/ConnectionHandlerDemo
RAM for global variables -|-|- arduino:samd:mkr1000|0|0 arduino:samd:mkrgsm1400|-8|0 arduino:samd:mkrnb1500|0|0 arduino:samd:mkrwan1300|0|0 arduino:samd:mkrwan1310|0|0 arduino:samd:mkrwifi1010|0|0 arduino:samd:nano_33_iot|0|0 esp8266:esp8266:huzzah|0|0
Click for full report CSV ``` Board,examples/ConnectionHandlerDemo
flash,examples/ConnectionHandlerDemo
RAM for global variables arduino:samd:mkr1000,0,0 arduino:samd:mkrgsm1400,-8,0 arduino:samd:mkrnb1500,0,0 arduino:samd:mkrwan1300,0,0 arduino:samd:mkrwan1310,0,0 arduino:samd:mkrwifi1010,0,0 arduino:samd:nano_33_iot,0,0 esp8266:esp8266:huzzah,0,0 ```