Support for WPA2 Enterprise

arduino-libraries / Arduino_ConnectionHandler

GNU General Public License v3.0

97 stars 36 forks source link

Support for WPA2 Enterprise #65

Open jesmith-all opened 3 years ago

jesmith-all commented 3 years ago

Adds optional argument to WifiConnectionHandler constructor to pass a username
Conditional in .cpp checks if value has been set, calls on .begin or .beginEnterprise accordingly
Critical to use at universities
If merged, would allow students on university networks to use IoT Cloud without modifying a local copy of the library

CLAassistant commented 3 years ago

All committers have signed the CLA.

facchinm commented 3 years ago

Hi @jesmith-all , thanks for the PR! However, the API is a bit confusing IMO; I'd prefer a derived class similar to https://github.com/arduino-libraries/Arduino_ConnectionHandler/pull/63 that could be "selected" by the user as soon as https://github.com/arduino-libraries/ArduinoIoTCloud/pull/265 get merged and the online "stub" generator updated. This would allow calling beginEnterprise() with all the different options (like entity/ca if needed).

jesmith-all commented 3 years ago

@facchinm (@brownby)

Fair enough. With an active course now and more around the corner, I sought the path of least resistance in edits that would add the functionality as a stop gap, but you're right that this isn't as clean as it could be.

I have not been tracking these other developments, but it's great to hear that you've got a vision for how things could coalesce. I'll take a look and circle back.

olipinski commented 1 year ago

@facchinm Does it still need to be in a derived class? I see that the project file structure has changed quite a bit since this PR, but if it still needs to be a separate class, I can give it a go.