search

arduino-libraries / Arduino_ConnectionHandler

GNU General Public License v3.0
97 stars 36 forks source link

Fix required firmware version check #86

Closed pennam closed 2 years ago

github-actions[bot] commented 2 years ago

Memory usage change @ f56b1b9b19c73a91f4fe6e595b02255c8a4126e9

Board flash % RAM for global variables %
arduino:mbed:envie_m7 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect :small_red_triangle: +190 - +190 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nicla:nicla_vision 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 :small_red_triangle: +192 - +192 +0.07 - +0.07 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1300 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1310 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 :small_red_triangle: +208 - +208 +0.08 - +0.08 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot :small_red_triangle: +208 - +208 +0.08 - +0.08 0 - 0 0.0 - 0.0
esp32:esp32:esp32 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
esp8266:esp8266:huzzah 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table Board|examples/ConnectionHandlerDemo
flash|%|examples/ConnectionHandlerDemo
RAM for global variables|% -|-|-|-|- arduino:mbed:envie_m7|0|0.0|0|0.0 arduino:mbed_nano:nanorp2040connect|190|0.0|0|0.0 arduino:mbed_nicla:nicla_vision|0|0.0|0|0.0 arduino:samd:mkr1000|192|0.07|0|0.0 arduino:samd:mkrgsm1400|0|0.0|0|0.0 arduino:samd:mkrnb1500|0|0.0|0|0.0 arduino:samd:mkrwan1300|0|0.0|0|0.0 arduino:samd:mkrwan1310|0|0.0|0|0.0 arduino:samd:mkrwifi1010|208|0.08|0|0.0 arduino:samd:nano_33_iot|208|0.08|0|0.0 esp32:esp32:esp32|0|0.0|0|0.0 esp8266:esp8266:huzzah|0|0.0|0|0.0
Click for full report CSV ``` Board,examples/ConnectionHandlerDemo
flash,%,examples/ConnectionHandlerDemo
RAM for global variables,% arduino:mbed:envie_m7,0,0.0,0,0.0 arduino:mbed_nano:nanorp2040connect,190,0.0,0,0.0 arduino:mbed_nicla:nicla_vision,0,0.0,0,0.0 arduino:samd:mkr1000,192,0.07,0,0.0 arduino:samd:mkrgsm1400,0,0.0,0,0.0 arduino:samd:mkrnb1500,0,0.0,0,0.0 arduino:samd:mkrwan1300,0,0.0,0,0.0 arduino:samd:mkrwan1310,0,0.0,0,0.0 arduino:samd:mkrwifi1010,208,0.08,0,0.0 arduino:samd:nano_33_iot,208,0.08,0,0.0 esp32:esp32:esp32,0,0.0,0,0.0 esp8266:esp8266:huzzah,0,0.0,0,0.0 ```
pennam commented 2 years ago

I believe it worked before too. Now it's on the safe side though =)

no, it was not working as intended. It was comparing pointers to the string not the string content itself.

aentinger commented 2 years ago

no, it was not working as intended. It was comparing pointers to the string not the string content itself.

Good catch than :rocket: