search

arduino-libraries / Arduino_GigaDisplay

Library for controlling the RGB on the GIGA Display Shield. It contains, also, a set of examples to use the display.
9 stars 3 forks source link

Adapt/retire SquareLine-based example #27

Closed aliphys closed 6 months ago

aliphys commented 6 months ago

As highlighted by @leonardocavagnis in https://github.com/arduino-libraries/Arduino_GigaDisplay/pull/22:

Cannot port squarelinestudio_lvgl to v9 because SquareLine Studio is no longer compatible with LVGL. It works only with v8 and earlier.

The squarelinestudio_lvgl_v8.ino is no longer relevant and should be adapted/deleted since:

Possible solutions

Option Positive Negative
Remove Quick and easy fix, reduced future maintenance. No Zendesk tickets mentioning this specific example, so should have minimal affect on Users Library functionality scope reduced
Adapt Retain compatibility with SquareLine Studio Additional effort for a discontinued feature
per1234 commented 6 months ago

I don't have any opinion regarding whether or not the example should be removed. However, it should be noted that SquareLine Studio have stated they do plan to provide LVGL 9.x support:

https://forum.squareline.io/t/q-plans-timeline-for-lvgl-9-observer-support/2782/2

LVGL9 support is planned for the upcoming April release. (And we’d like to support observers in the future.)

The library/core have backwards compatibility with LVGL 8.x, so even at this time when SquareLine Studio is only compatible with LVGL 8.x, it is still possible for users to use this example by simply installing version 8.4.0 of the "lvgl" library.

leonardocavagnis commented 6 months ago

I'm agree with @per1234. Do not retire squarelinestudio_lvgl_v8.ino, we'll do the porting to LVGLv9 when the new SquareLine studio will be release.

aliphys commented 6 months ago

Thanks for the insight @per1234 and @leonardocavagnis . Closing this issue, and created issue https://github.com/arduino-libraries/Arduino_GigaDisplay/issues/29 regarding the porting task @leonardocavagnis mentioned.