search

arduino-libraries / Arduino_MKRIoTCarrier

Use the features included with the Arduino MKR IoT Carrier
https://store.arduino.cc/mkr-iot-carrier
GNU Lesser General Public License v2.1
18 stars 11 forks source link

Rev4 #55

Closed maidnl closed 2 years ago

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

Rocketct commented 2 years ago

@per1234 shall be added the dependencies to this library (BME68x Sensor library) on the github actions, can you handle it?

per1234 commented 2 years ago

shall be added the dependencies to this library (BME68x Sensor library) on the github actions, can you handle it?

Hi @Rocketct. I have submitted a pull request for it against the head branch of this PR (meaning it will automatically become part of this PR if that one is merged): https://github.com/maidnl/Arduino_MKRIoTCarrier/pull/2

Please let me know if anything else is required.

Rocketct commented 2 years ago

sorry @per1234 there was also another library to which the board was dependent Arduino_LSM6DSOX, but i can handle it adding directly it in the this PR itself by editing the commit file itself

per1234 commented 2 years ago

Thanks @Rocketct. Please let me know if I can be of any assistance in the event additional adjustments to the CI are needed.

I did have one question: I see that the "Arduino_LSM6DS3" library dependency has been replaced by "Arduino_LSM6DSOX":

https://github.com/arduino-libraries/Arduino_MKRIoTCarrier/pull/55/files#diff-f267f9ae2f5d5d56a1dbb305e95d40d4408d9ee7f71357f1f67fb18c29b7f082L11

-depends=Arduino_APDS9960,Arduino_BQ24195,Arduino_HTS221,Arduino_LPS22HB,Arduino_LSM6DS3,Adafruit BusIO,Adafruit DotStar,Adafruit GFX Library,Adafruit ST7735 and ST7789 Library,Arduino_MCHPTouch,TFT_eSPI
+depends=Arduino_APDS9960,Arduino_BQ24195,Arduino_HTS221,Arduino_LPS22HB,Arduino_LSM6DSOX,BME68x Sensor library,Adafruit BusIO,Adafruit DotStar,Adafruit GFX Library,Adafruit ST7735 and ST7789 Library,Arduino_MCHPTouch,TFT_eSPI

However, the workflow is still configured to install the "Arduino_LSM6DS3" library:

https://github.com/arduino-libraries/Arduino_MKRIoTCarrier/blob/d0dee5c7c0f3bb2fb0f398edb6b8ef8c516d5f77/.github/workflows/Compile%20Examples.yml#L54

If it is no longer needed, we should remove that library from the workflow configuration for the sake of efficiency and maintainability.

facchinm commented 2 years ago

Superseeded by #58