search

arduino-libraries / Arduino_MKRIoTCarrier

Use the features included with the Arduino MKR IoT Carrier
https://store.arduino.cc/mkr-iot-carrier
GNU Lesser General Public License v2.1
17 stars 12 forks source link

Compiler Warnings #67

Closed phant0mias closed 7 months ago

phant0mias commented 1 year ago

I use the library with PlatformIO and detected some compiler warnings:

1) In the function int QtouchClass::available() the statement: 

p_selfcap_measure_data->measurement_done_touch == 0u;

makes no sense

2) in the file Arduino_MKRIoTCarrier_Qtouch.h

static bool _available = false;

is not used

3) In AirQualityClass.cpp

the function:

do not return a value in case _revision is not equal BOARD_REVISION_2 (will be fixed by https://github.com/arduino-libraries/Arduino_MKRIoTCarrier/pull/76)

alranel commented 1 year ago

Good catch @phant0mias. A pull request is welcome :)

phant0mias commented 1 year ago

OK, I will do it

phant0mias commented 12 months ago

Hi, sorry for the long delay. I made a pull request for a part of the files

phant0mias commented 7 months ago

is merged