search

arduino-libraries / Arduino_MachineControl

GNU Lesser General Public License v2.1
38 stars 29 forks source link

Dual Core Example/Functionality #85

Open will2055 opened 2 years ago

will2055 commented 2 years ago

There isn't an example to use the dual core feature of the H7 controller. The current library won't compile for M4 core unless #ifdef CORE_CM7 ... #endif are used to contain the RS485 and COM classes.

The Machine Control board is advertised to feature the dual core power of the Portenta H7 controller. However, the current library doesn't allow for that.

elastra21 commented 2 years ago

Does anybody fixed this?, I'm facing the same issue

elastra21 commented 2 years ago

Fixed, for those with the same issue https://github.com/elastra21/Arduino_MachineControl

JustusRijke commented 2 years ago

same issue here, would be great if @elastra21 fix can be merged to the library

will2055 commented 2 years ago

@elastra21 Could you provide a brief summary of what changes you made for this fix?

elastra21 commented 2 years ago

Yeah as you commented at the start, I just change this '#ifdef CORE_CM7 in Arduino_MachineControl.h

manchoz commented 2 years ago

Hi @elastra21, would you mind creating a PR from your proposed changes? This will help discussing your proposed changes and eventually merging them.

elastra21 commented 1 year ago

Hi @elastra21, would you mind creating a PR from your proposed changes? This will help discussing your proposed changes and eventually merging them.

PR submitted.