Closed per1234 closed 3 years ago
the correct naming is DISPLAY_CLKP and DISPLAY_CLKN
@pennam The purpose of this pull request is to sync the keywords with the code of the library. The library currently uses the names DISPLAY_CLKP and DISPLAY_CLKN: https://github.com/bcmi-labs/Arduino_PortentaBreakoutLibrary/blob/main/Arduino_PortentaBreakoutCarrier.h#L122-L123
DISPLAY_CLKP
DISPLAY_CLKN
If the code is changed to match the pinout diagram, then the keywords should be changed at the same time, but that change is outside the scope of the stated purpose of this PR.
@per1234 Ah, sorry. Now i see. I will merge this and then open another pr to update keywords and source code! Thanks!
@pennam The purpose of this pull request is to sync the keywords with the code of the library. The library currently uses the names
DISPLAY_CLKP
andDISPLAY_CLKN
: https://github.com/bcmi-labs/Arduino_PortentaBreakoutLibrary/blob/main/Arduino_PortentaBreakoutCarrier.h#L122-L123If the code is changed to match the pinout diagram, then the keywords should be changed at the same time, but that change is outside the scope of the stated purpose of this PR.