Separation of RTD and TC classes confusing

arduino-libraries / Arduino_PortentaMachineControl

The official, revamped Arduino Library for the Portenta Machine Control.

Mozilla Public License 2.0

10 stars 8 forks source link

Separation of RTD and TC classes confusing #14

Closed JHSawatzki closed 1 week ago

JHSawatzki commented 5 months ago

Both probe types use the same inputs/channels so the current implementation is confusing, espacially when using both types in the same project.

I suggest using a shared class like I did in my fork of the old lib, see https://github.com/JHSawatzki/Arduino_MachineControl/blob/master/src/Arduino_MachineControl.h

I could probably also provide a pull request with an implementation not breaking your current API.

leonardocavagnis commented 5 months ago

Hi @JHSawatzki, Thanks for the proposal! I don't completely agree with your point. We moved to separate classes to avoid using the "double dot" notation (temp_probes.rtd.) of the deprecated one. However, I invite you to propose your solution in a PR, and I'll analyze it. 😊