search

arduino-libraries / Arduino_USBHostMbed5

Apache License 2.0
4 stars 11 forks source link

Fixes connect() bug, crash bug, I/O error bug, and more. #23

Closed alrvid closed 1 year ago

alrvid commented 1 year ago
  1. Fixes USB thumb drive remove and insert again bug
  2. Fixes crash on mount() before connect() bug
  3. Fixes incorrect comment about stall handling
  4. Fixes I/O errors when writing to some USB thumb drive models
  5. Fixes incorrectly named constant (MAX_NYET_RETRY to MAX_NOTREADY_RETRY)
  6. Improves the source code comments in several locations
github-actions[bot] commented 1 year ago

Memory usage change @ d8287c34cbdad295e514d8975b599b139bbde2b0

Board flash % RAM for global variables %
arduino:mbed_giga:giga :small_red_triangle: +64 - +128 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed_opta:opta :small_red_triangle: +64 - +128 +0.01 - +0.02 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
Click for full report table Board|`examples/DirList`
flash|%|`examples/DirList`
RAM for global variables|%|`examples/FileRead`
flash|%|`examples/FileRead`
RAM for global variables|%|`examples/FileWrite`
flash|%|`examples/FileWrite`
RAM for global variables|%|`examples/OptaDirList`
flash|%|`examples/OptaDirList`
RAM for global variables|%|`examples/PortentaOTA`
flash|%|`examples/PortentaOTA`
RAM for global variables|% -|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|- `arduino:mbed_giga:giga`|128|0.01|0|0.0|128|0.01|0|0.0|128|0.01|0|0.0|64|0.0|0|0.0|64|0.0|0|0.0 `arduino:mbed_opta:opta`|128|0.02|0|0.0|64|0.01|0|0.0|128|0.02|0|0.0|64|0.01|0|0.0|128|0.02|0|0.0 `arduino:mbed_portenta:envie_m7`|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A
Click for full report CSV ``` Board,examples/DirList
flash,%,examples/DirList
RAM for global variables,%,examples/FileRead
flash,%,examples/FileRead
RAM for global variables,%,examples/FileWrite
flash,%,examples/FileWrite
RAM for global variables,%,examples/OptaDirList
flash,%,examples/OptaDirList
RAM for global variables,%,examples/PortentaOTA
flash,%,examples/PortentaOTA
RAM for global variables,% arduino:mbed_giga:giga,128,0.01,0,0.0,128,0.01,0,0.0,128,0.01,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0 arduino:mbed_opta:opta,128,0.02,0,0.0,64,0.01,0,0.0,128,0.02,0,0.0,64,0.01,0,0.0,128,0.02,0,0.0 arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A ```
alrvid commented 1 year ago

The Spell Check failure is because a comment correctly contains the word "unstall" - as in clearing the halted feature of the USB EPs when receiving a stall. It's not supposed to be "uninstall" even though that would satisfy Spell Check.

github-actions[bot] commented 1 year ago

Memory usage change @ 69326c041fa5603749654f8149e9bf36a0789a7d

Board flash % RAM for global variables %
arduino:mbed_giga:giga :small_red_triangle: +64 - +128 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed_opta:opta :small_red_triangle: +64 - +128 +0.01 - +0.02 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
Click for full report table Board|`examples/DirList`
flash|%|`examples/DirList`
RAM for global variables|%|`examples/FileRead`
flash|%|`examples/FileRead`
RAM for global variables|%|`examples/FileWrite`
flash|%|`examples/FileWrite`
RAM for global variables|%|`examples/OptaDirList`
flash|%|`examples/OptaDirList`
RAM for global variables|%|`examples/PortentaOTA`
flash|%|`examples/PortentaOTA`
RAM for global variables|% -|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|- `arduino:mbed_giga:giga`|128|0.01|0|0.0|128|0.01|0|0.0|128|0.01|0|0.0|64|0.0|0|0.0|64|0.0|0|0.0 `arduino:mbed_opta:opta`|128|0.02|0|0.0|64|0.01|0|0.0|128|0.02|0|0.0|64|0.01|0|0.0|128|0.02|0|0.0 `arduino:mbed_portenta:envie_m7`|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A
Click for full report CSV ``` Board,examples/DirList
flash,%,examples/DirList
RAM for global variables,%,examples/FileRead
flash,%,examples/FileRead
RAM for global variables,%,examples/FileWrite
flash,%,examples/FileWrite
RAM for global variables,%,examples/OptaDirList
flash,%,examples/OptaDirList
RAM for global variables,%,examples/PortentaOTA
flash,%,examples/PortentaOTA
RAM for global variables,% arduino:mbed_giga:giga,128,0.01,0,0.0,128,0.01,0,0.0,128,0.01,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0 arduino:mbed_opta:opta,128,0.02,0,0.0,64,0.01,0,0.0,128,0.02,0,0.0,64,0.01,0,0.0,128,0.02,0,0.0 arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A ```
github-actions[bot] commented 1 year ago

Memory usage change @ c333aa44c0833caf344ffc3ef2fd02267885bc41

Board flash % RAM for global variables %
arduino:mbed_giga:giga :small_red_triangle: +64 - +128 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed_opta:opta :small_red_triangle: +64 - +128 +0.01 - +0.02 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
Click for full report table Board|`examples/DirList`
flash|%|`examples/DirList`
RAM for global variables|%|`examples/FileRead`
flash|%|`examples/FileRead`
RAM for global variables|%|`examples/FileWrite`
flash|%|`examples/FileWrite`
RAM for global variables|%|`examples/OptaDirList`
flash|%|`examples/OptaDirList`
RAM for global variables|%|`examples/PortentaOTA`
flash|%|`examples/PortentaOTA`
RAM for global variables|% -|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|- `arduino:mbed_giga:giga`|128|0.01|0|0.0|128|0.01|0|0.0|128|0.01|0|0.0|128|0.01|0|0.0|64|0.0|0|0.0 `arduino:mbed_opta:opta`|128|0.02|0|0.0|64|0.01|0|0.0|128|0.02|0|0.0|64|0.01|0|0.0|128|0.02|0|0.0 `arduino:mbed_portenta:envie_m7`|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A
Click for full report CSV ``` Board,examples/DirList
flash,%,examples/DirList
RAM for global variables,%,examples/FileRead
flash,%,examples/FileRead
RAM for global variables,%,examples/FileWrite
flash,%,examples/FileWrite
RAM for global variables,%,examples/OptaDirList
flash,%,examples/OptaDirList
RAM for global variables,%,examples/PortentaOTA
flash,%,examples/PortentaOTA
RAM for global variables,% arduino:mbed_giga:giga,128,0.01,0,0.0,128,0.01,0,0.0,128,0.01,0,0.0,128,0.01,0,0.0,64,0.0,0,0.0 arduino:mbed_opta:opta,128,0.02,0,0.0,64,0.01,0,0.0,128,0.02,0,0.0,64,0.01,0,0.0,128,0.02,0,0.0 arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A ```
github-actions[bot] commented 1 year ago

Memory usage change @ 8c3c35a82e97ddc6ee35ba853759e8832af9a885

Board flash % RAM for global variables %
arduino:mbed_giga:giga :small_red_triangle: +64 - +128 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed_opta:opta :small_red_triangle: +64 - +128 +0.01 - +0.02 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
Click for full report table Board|`examples/DirList`
flash|%|`examples/DirList`
RAM for global variables|%|`examples/FileRead`
flash|%|`examples/FileRead`
RAM for global variables|%|`examples/FileWrite`
flash|%|`examples/FileWrite`
RAM for global variables|%|`examples/OptaDirList`
flash|%|`examples/OptaDirList`
RAM for global variables|%|`examples/PortentaOTA`
flash|%|`examples/PortentaOTA`
RAM for global variables|% -|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|- `arduino:mbed_giga:giga`|128|0.01|0|0.0|128|0.01|0|0.0|128|0.01|0|0.0|128|0.01|0|0.0|64|0.0|0|0.0 `arduino:mbed_opta:opta`|128|0.02|0|0.0|64|0.01|0|0.0|128|0.02|0|0.0|64|0.01|0|0.0|128|0.02|0|0.0 `arduino:mbed_portenta:envie_m7`|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A
Click for full report CSV ``` Board,examples/DirList
flash,%,examples/DirList
RAM for global variables,%,examples/FileRead
flash,%,examples/FileRead
RAM for global variables,%,examples/FileWrite
flash,%,examples/FileWrite
RAM for global variables,%,examples/OptaDirList
flash,%,examples/OptaDirList
RAM for global variables,%,examples/PortentaOTA
flash,%,examples/PortentaOTA
RAM for global variables,% arduino:mbed_giga:giga,128,0.01,0,0.0,128,0.01,0,0.0,128,0.01,0,0.0,128,0.01,0,0.0,64,0.0,0,0.0 arduino:mbed_opta:opta,128,0.02,0,0.0,64,0.01,0,0.0,128,0.02,0,0.0,64,0.01,0,0.0,128,0.02,0,0.0 arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A ```
github-actions[bot] commented 1 year ago

Memory usage change @ a4ac6d1b169d8f34664e4637b6593df31b772133

Board flash % RAM for global variables %
arduino:mbed_giga:giga :small_red_triangle: +64 - +128 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed_opta:opta :small_red_triangle: +64 - +128 +0.01 - +0.02 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
Click for full report table Board|`examples/DirList`
flash|%|`examples/DirList`
RAM for global variables|%|`examples/FileRead`
flash|%|`examples/FileRead`
RAM for global variables|%|`examples/FileWrite`
flash|%|`examples/FileWrite`
RAM for global variables|%|`examples/OptaDirList`
flash|%|`examples/OptaDirList`
RAM for global variables|%|`examples/PortentaOTA`
flash|%|`examples/PortentaOTA`
RAM for global variables|% -|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|- `arduino:mbed_giga:giga`|128|0.01|0|0.0|128|0.01|0|0.0|128|0.01|0|0.0|128|0.01|0|0.0|64|0.0|0|0.0 `arduino:mbed_opta:opta`|128|0.02|0|0.0|64|0.01|0|0.0|128|0.02|0|0.0|64|0.01|0|0.0|128|0.02|0|0.0 `arduino:mbed_portenta:envie_m7`|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A
Click for full report CSV ``` Board,examples/DirList
flash,%,examples/DirList
RAM for global variables,%,examples/FileRead
flash,%,examples/FileRead
RAM for global variables,%,examples/FileWrite
flash,%,examples/FileWrite
RAM for global variables,%,examples/OptaDirList
flash,%,examples/OptaDirList
RAM for global variables,%,examples/PortentaOTA
flash,%,examples/PortentaOTA
RAM for global variables,% arduino:mbed_giga:giga,128,0.01,0,0.0,128,0.01,0,0.0,128,0.01,0,0.0,128,0.01,0,0.0,64,0.0,0,0.0 arduino:mbed_opta:opta,128,0.02,0,0.0,64,0.01,0,0.0,128,0.02,0,0.0,64,0.01,0,0.0,128,0.02,0,0.0 arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A ```
github-actions[bot] commented 1 year ago

Memory usage change @ 3a90c058f57701b4ba1914ce11094e6d3f3881c1

Board flash % RAM for global variables %
arduino:mbed_giga:giga :small_red_triangle: +64 - +128 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed_opta:opta :small_red_triangle: +64 - +128 +0.01 - +0.02 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
Click for full report table Board|`examples/DirList`
flash|%|`examples/DirList`
RAM for global variables|%|`examples/FileRead`
flash|%|`examples/FileRead`
RAM for global variables|%|`examples/FileWrite`
flash|%|`examples/FileWrite`
RAM for global variables|%|`examples/OptaDirList`
flash|%|`examples/OptaDirList`
RAM for global variables|%|`examples/PortentaOTA`
flash|%|`examples/PortentaOTA`
RAM for global variables|% -|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|- `arduino:mbed_giga:giga`|128|0.01|0|0.0|128|0.01|0|0.0|128|0.01|0|0.0|128|0.01|0|0.0|64|0.0|0|0.0 `arduino:mbed_opta:opta`|128|0.02|0|0.0|64|0.01|0|0.0|128|0.02|0|0.0|64|0.01|0|0.0|128|0.02|0|0.0 `arduino:mbed_portenta:envie_m7`|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A|N/A
Click for full report CSV ``` Board,examples/DirList
flash,%,examples/DirList
RAM for global variables,%,examples/FileRead
flash,%,examples/FileRead
RAM for global variables,%,examples/FileWrite
flash,%,examples/FileWrite
RAM for global variables,%,examples/OptaDirList
flash,%,examples/OptaDirList
RAM for global variables,%,examples/PortentaOTA
flash,%,examples/PortentaOTA
RAM for global variables,% arduino:mbed_giga:giga,128,0.01,0,0.0,128,0.01,0,0.0,128,0.01,0,0.0,128,0.01,0,0.0,64,0.0,0,0.0 arduino:mbed_opta:opta,128,0.02,0,0.0,64,0.01,0,0.0,128,0.02,0,0.0,64,0.01,0,0.0,128,0.02,0,0.0 arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A ```
facchinm commented 1 year ago

Lovely work, thanks a lot!