Closed aliphys closed 10 months ago
@per1234 Do we know why the compile-sketches
workflow is stuck in the Expected
status?
@aliphys because this change does not change any file that would trigger that action. It won't run.
@per1234 I guess the question is, if that action should run for any change to any file (remove the file patterns in the workflow file), or if we should remove that branch protection rule. I think I'd go with the first option.
I'd go with the first option
That is a reasonable choice. The purpose of the paths filter is to avoid unnecessary runs of the workflow for changes that are not relevant to the compilation of sketches. But the occasional unnecessary workflow run doesn't do any significant harm. Public repositories have unlimited free GitHub Actions minutes.
It is really unfortunate that GitHub's implementation of required status checks isn't more intelligent. The system should be smart enough to understand that it should not impose the requirement when the workflow run wasn't triggered
To make the readme more applicable to users:
complie-sketches
workflow does indeed compile for it, and we have tested on the physical Opta as well https://github.com/arduino-libraries/Arduino_UnifiedStorage/blob/04d4dbb7de0b337d473157e5e3d020e54634f549/README.md?plain=1#L48.ino
sketches for people who want more details. https://github.com/arduino-libraries/Arduino_UnifiedStorage/blob/04d4dbb7de0b337d473157e5e3d020e54634f549/README.md?plain=1#L8-L12 @cristidragomir97 can you confirm the compatibility list is accurate?