arduino-libraries / Arduino_UnifiedStorage

Read and write files to flash, USB mass storage and SD cards in a unified way.
GNU Lesser General Public License v2.1
11 stars 3 forks source link

[AE-158] Make readme more user-friendly #18

Closed aliphys closed 10 months ago

aliphys commented 10 months ago

To make the readme more applicable to users:

aliphys commented 10 months ago

@per1234 Do we know why the compile-sketches workflow is stuck in the Expected status? image

sebromero commented 10 months ago

@aliphys because this change does not change any file that would trigger that action. It won't run.

sebromero commented 10 months ago

@per1234 I guess the question is, if that action should run for any change to any file (remove the file patterns in the workflow file), or if we should remove that branch protection rule. I think I'd go with the first option.

per1234 commented 10 months ago

I'd go with the first option

That is a reasonable choice. The purpose of the paths filter is to avoid unnecessary runs of the workflow for changes that are not relevant to the compilation of sketches. But the occasional unnecessary workflow run doesn't do any significant harm. Public repositories have unlimited free GitHub Actions minutes.

It is really unfortunate that GitHub's implementation of required status checks isn't more intelligent. The system should be smart enough to understand that it should not impose the requirement when the workflow run wasn't triggered