Refer to HID to improve the code

[MRNIU]

Hey guys, I tried replace current code with HID's keyboard control code. Now we support more keys, and US/DE layout. Please point out any mistakes. Thanks!

[PaulStoffregen]

Many of the source files say "See the readme for credit to other people". But this PR appears to not have that readme file.

Before this code is merged, at the very least that readme file should be included somehow, or the info about authors and contributors should be included in the source.

[MRNIU]

@per1234 My fault

[MRNIU]

Do we have any test case?

[MRNIU]

I do not currently have an Arduino Leonardo available, and I will solve this problem in the next few days.

[PaulStoffregen]

The header files still say "See the readme for credit to other people", but do not include this information. Please find and put this information into the header files.

If any of my code from Teensy was used (I strongly suspect it was - especially the keyboard layouts), I do NOT approve of it being published in this manner, without attribution, and with the header claiming the copyright is only to NicoHood.

[MRNIU]

I apologize if any infringement, but I had add the README file here.

About keyboard layouts, they are copy from NicoHood/HID with few changes, not from Teensy.

[per1234]

I believe the statement in the headers:

Copyright (c) 2014-2015 NicoHood See the readme for credit to other people.

was written before the documentation was moved to the repository's wiki, and never updated after the move: https://github.com/NicoHood/HID#wiki

All documentation moved to the wiki page.

The "Useful Links/Credit" page of the wiki has a lot of credits, including one for Paul Stoffregen's Teensy Core: https://github.com/NicoHood/HID/wiki/Useful-Links-Credits

So I don't think the readme you added that only gives credit to NicoHood and you is sufficient.

[MRNIU]

I am so sorry for that, please excuse my carelessness.

I have added those information and submitted an issue for update the credits info.

Apologize to you again @PaulStoffregen

[PaulStoffregen]

Yes, that readme file confirms some of this code came from my work.

Please remove the portions with came from the Teensy core library.

[MRNIU]

@PaulStoffregen Already remove those codes. @per1234 I will rewrite the keymap, which will take a few days, Thank you.

[MRNIU]

@per1234 , Hi, I thought about it for a few days, checked the code of NicoHood/HID, and found that moving it here does not seem to make much sense. So I just refactored the code. Hope this is useful.

[NicoHood]

Ouuuf. That's a very old statement. I have mainly three ideas about this:

• (At that time) it was decided to keep the arduino HID features simple and let my library provide the additional features. I have no problem with merging this upstream, however I want to remind about that in case it was forgotten. https://github.com/arduino/Arduino/pull/1803#issuecomment-141959713
• The "credit thing" is very blurry, I would do it better today. When I started the project, I've copied code, tried it out and those links are the onces that helped me. At some time I did a complete rewrite if the code. I dont know how to correctly credit in this case. I've mainly added those links for people to get additional information and examples beside my library implementation. So I would not call my "copyright notice" that critical, we can simply remove it.
• The code from @PaulStoffregen was already removed, as he requested that year ago already (and it was not really working properly in my project)

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}