Closed Picsiri closed 1 year ago
Memory usage change @ 6124b163531bd7b0aa13e764dd2065628b29f45d
Board | flash | % | RAM for global variables | % |
---|---|---|---|---|
arduino:avr:leonardo |
0 - 0 | 0.0 - 0.0 | 0 - 0 | 0.0 - 0.0 |
arduino:sam:arduino_due_x_dbg |
0 - 0 | 0.0 - 0.0 | N/A | N/A |
arduino:samd:mkrzero |
0 - 0 | 0.0 - 0.0 | 0 - 0 | 0.0 - 0.0 |
@edgar-bonet
I am not a maintainer
Would you fancy becoming it :slightly_smiling_face: ? I wanted to ask you for some time, feel free to say no if you see it as a burden but I'd really love to give you the freedom to apply changes and speedup the whole process :wink:
@facchinm
Would you fancy becoming it 🙂 ?
Well, yes! I would be honored. Really.
Note that I have only one Arduino on which I can test this library: an Arduino Micro. I thus cannot check cross-architecture compatibility. Is this a problem?
I'd really love to give you the freedom to apply changes and speedup the whole process 😉
What would be the recommended way of handling the pull request then? Wait for the author to amend or respond to the feedback? Or push my recommended changes on top of his commit and then merge?
What would be the recommended way of handling the pull request then? Wait for the author to amend or respond to the feedback? Or push my recommended changes on top of his commit and then merge?
Man, go ahead! :D
Memory usage change @ 00128df24d038d11237383903aca44c7045a2441
Board | flash | % | RAM for global variables | % |
---|---|---|---|---|
arduino:avr:leonardo |
0 - 0 | 0.0 - 0.0 | 0 - 0 | 0.0 - 0.0 |
arduino:sam:arduino_due_x_dbg |
0 - 0 | 0.0 - 0.0 | N/A | N/A |
arduino:samd:mkrzero |
0 - 0 | 0.0 - 0.0 | 0 - 0 | 0.0 - 0.0 |
Merged. @Picsiri: thanks for your contribution!
Title says everything