arduino-libraries / LiquidCrystal

Liquid Crystal Library for Arduino
http://arduino.cc/
256 stars 169 forks source link

Arduino reference code CreateChar problem #26

Open Englishscone1 opened 4 years ago

Englishscone1 commented 4 years ago

Hey everyone,

https://www.arduino.cc/en/Reference/LiquidCrystalCreateChar

The example code for the Arduino Reference contains this byte:

byte smiley[8] = { 0b00000, 0b00000, 0b01010, 0b00000, 0b00000, 0b10001, 0b01110, 0b00000 };

When creating this character, the code only used 7 bytes, not 8. With beginners in mind, I would recommend adding the unneeded 8th byte "0b00000" to give a clear template. Without all these bytes a beginner may not understand how to create a full character if the instructions were not completely read.