search

arduino-libraries / LiquidCrystal

Liquid Crystal Library for Arduino
http://arduino.cc/
246 stars 169 forks source link

Added read functions to the LiquidCrystal library #7

Closed agdl closed 8 years ago

agdl commented 8 years ago

From @Chisalita on July 24, 2013 13:12

Added functions to read data from LCD, to delete last character, to delete a character at specified position, get current position, get character from a position and get more characters at once, making it faster.

Review on Reviewable

Copied from original issue: arduino/Arduino/pull/1517

agdl commented 8 years ago

From @Chisalita on September 7, 2013 18:56

If there are any problems please tell me. I really want to know why it dose not get merged, with all my respect I appreciate your decision. Thank you for the time!

agdl commented 8 years ago

From @ArduinoBot on August 22, 2014 11:51

Can I build this pull request?

agdl commented 8 years ago

From @Chisalita on August 22, 2014 18:54

If you ask for my permission or something like that, then sure you can. If you ask in order to know that it works correctly, I can say that it was tested on my Uno before making the pull request.

agdl commented 8 years ago

From @ffissore on August 22, 2014 20:52

@Chisalita sorry for the comment from arduinobot. we are setting up automated build of all PRs, so that we can provide a downloadable version of the patched IDE

agdl commented 8 years ago

From @andresn on September 14, 2014 4:45

:+1: thanks for this!

agdl commented 8 years ago

From @matthijskooijman on September 14, 2014 10:3

I just noticed this PR. I like what it does, so I did a course review of the code. I've added some inline comments in the commit about things I think need to be changed. Overall, I think that the new functions added do not fit in the style of the other Arduino APIs completely and need some improvement. Also, you've removed a lot of trailing spaces (your editor probably did that) which are completely unrelated to the commit at hand and thus complicate review. I'm all for removing trailing whitespace, but you should do it in a separate commit then (which only changes whitespace). Alternatively, configure your editor to leave the whitespace alone. In either case, please update this pullrequest to remove the whitespace changes from the main commit (note that you can (force-)push to your branch to update this pullrequest).