search

arduino-libraries / MKRGSM

GNU Lesser General Public License v2.1
55 stars 51 forks source link

Handle SMS responses #104

Closed janakelarsson closed 3 years ago

janakelarsson commented 4 years ago

Hi, the current code will mis-interpret an SMS response for any SMS with the content "OK".

In this case the AT command response will contain "+CMGL: ...\r\nOK\r\n" which will be caught in MODEM::poll() during the readout of the response, and break the interpreter.

The pull request contains special handling of "+CMGL:" responses.

I tried to make the change as small as possible, and with as small runtime overhead as possible. It checks if the response contains an SMS response once, and if not, continues with the old code.

janakelarsson commented 4 years ago

Changed to be more robust. Still minimal code changes, but now the change makes sure that SMS content is ignored altogether. No longer adds a new _atCommandState value.