search

arduino-libraries / MKRWAN

An Arduino library for sending and receiving data using LoRaWAN protocol and LoRa® radios.
https://www.arduino.cc
GNU Lesser General Public License v3.0
88 stars 60 forks source link

Why are join/connected methods virtual? #119

Open matthijskooijman opened 2 years ago

matthijskooijman commented 2 years ago

Reading the code, I see that various join methods, and the connected method are declared virtual. Why is this? Are subclasses expected that only subclass these methods? Or is this just a typo / accidental copy-paste?

There are also some other methods overridden from the Stream class that are already virtual there, so those make sense to be virtual.

HeadBoffin commented 2 years ago

It would appear to be a muddle, hacked out of a GPS library - certainly not nice clean clear code for alterations.