search

arduino-libraries / NTPClient

Connect to a NTP server
542 stars 372 forks source link

Update NTPClient.cpp for millis() rollover #124

Closed masterx1981 closed 3 years ago

masterx1981 commented 3 years ago

Fix millis() rollover after 49 days

per1234 commented 3 years ago

not know what's gone wrong with the "}" at the end.

Previously, the file did not end in a newline (which is why it has the 🚫 icon). Because it's best practices to always end files with a newline, the GitHub editor force adds them. This results in an unfortunate irrelevant diff, but I place the blame on the file's previous poor formatting (and the lack of a CI system to check for such formatting violations). So I wouldn't worry about it.

masterx1981 commented 3 years ago

I'll retire this as i've notice that is absolutely useless, sorry!