NTPClient::sendNTPPacket() does not check whether this->_udp->beginPacket actually began.

arduino-libraries / NTPClient

Connect to a NTP server

533 stars 366 forks source link

NTPClient::sendNTPPacket() does not check whether this->_udp->beginPacket actually began. #162

Open JonathanJamesStewart opened 2 years ago

JonathanJamesStewart commented 2 years ago

https://github.com/arduino-libraries/NTPClient/blob/master/NTPClient.cpp#L200

When this->_udp->beginPacket(...) fails because of DNS lookup failure or some other reason this causes the device to panic when it tries to read the result.

MHotchin commented 1 year ago

Pull request #177 would fix this.