arduino-libraries / NTPClient

Connect to a NTP server
554 stars 376 forks source link

Allow setting timeOffset as long (fixes #72 #168) #181

Open Randomblock1 opened 2 years ago

Randomblock1 commented 2 years ago

timeOffset itself was already a long, but setTimeOffset only accepted integers. This should allow it to be set as long, so more timezones can be used.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

github-actions[bot] commented 2 years ago

Memory usage change @ 4a9c2aa0503ea1a095598ce80ac86de90b6d1322

Board flash % RAM for global variables %
esp8266:esp8266:huzzah 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table Board|examples/Advanced
flash|%|examples/Advanced
RAM for global variables|%|examples/Basic
flash|%|examples/Basic
RAM for global variables|%|examples/IsTimeSet
flash|%|examples/IsTimeSet
RAM for global variables|% -|-|-|-|-|-|-|-|-|-|-|-|- esp8266:esp8266:huzzah|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0|0|0.0
Click for full report CSV ``` Board,examples/Advanced
flash,%,examples/Advanced
RAM for global variables,%,examples/Basic
flash,%,examples/Basic
RAM for global variables,%,examples/IsTimeSet
flash,%,examples/IsTimeSet
RAM for global variables,% esp8266:esp8266:huzzah,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0 ```