search

arduino-libraries / NTPClient

Connect to a NTP server
533 stars 366 forks source link

Change signature of function to set the offset to long #203

Closed JM-FRANCE closed 4 months ago

JM-FRANCE commented 4 months ago

The function expects an int, yet the instance variable is a long. On some architectures it’s not the same number of bytes

https://github.com/arduino-libraries/NTPClient/blob/01261a9487d246f4284f6ac04a117a71d4053c7d/NTPClient.cpp#L172

JM-FRANCE commented 4 months ago

I had not seen

https://github.com/arduino-libraries/NTPClient/pull/181

should be taken into account in the code…