timeout should be configurable

arduino-libraries / NTPClient

Connect to a NTP server

542 stars 372 forks source link

timeout should be configurable #95

Open songokas opened 4 years ago

songokas commented 4 years ago

timeout should be configurable and it should consider network delay

Nora465 commented 3 years ago

Hey, thanks for your PR ! But there is a problem on line 105, the calculation of "_lastUpdate" use the old "version" of timeout. And it create a delay of approximately 8 to 10 seconds with "GetEpochTime". I corrected it here for myself, so feel free to re-use (or modify) it !

CLAassistant commented 3 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Tomas Jakstas seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}