arduino / Arduino-Science-Journal-iOS

Use the sensors in your mobile devices to perform science experiments. Science doesn’t just happen in the classroom or lab—tools like Science Journal let you see how the world works with just your phone.
http://arduino.cc/education
Apache License 2.0
22 stars 9 forks source link

Adjust permissions guide layout for small screens #15

Closed emiliopavia closed 4 years ago

emiliopavia commented 4 years ago

Checklist

Motivation and Context

This PR fixes #14.

Description

I've adjusted some auto layout constraints in order to better fit in small screens. However I cannot guarantee that this will work for every language, as some labels might be too long to fit with this rigid design.

In the future I'd also suggest to remove the permissions request at the first launch, as it doesn't fit well with the iOS HIG. Instead we should ask for permissions on demand, when the user might need them.

Attached you can see screenshots of the fixed layout.

Simulator Screen Shot - iPhone SE (1st generation) - 2020-09-09 at 11 15 17

Simulator Screen Shot - iPhone SE (1st generation) - 2020-09-09 at 11 15 20

Simulator Screen Shot - iPhone SE (1st generation) - 2020-09-09 at 11 15 23

Simulator Screen Shot - iPhone SE (1st generation) - 2020-09-09 at 11 15 27

Simulator Screen Shot - iPhone SE (1st generation) - 2020-09-09 at 11 15 30

Simulator Screen Shot - iPhone SE (1st generation) - 2020-09-09 at 11 15 32

emiliopavia commented 4 years ago

Honestly I wouldn't spend too much time on such a small edge case. I can try, but instead I would rewrite the entire view controller when really needed.