arduino / Arduino-Science-Journal-iOS

Use the sensors in your mobile devices to perform science experiments. Science doesn’t just happen in the classroom or lab—tools like Science Journal let you see how the world works with just your phone.
http://arduino.cc/education
Apache License 2.0
22 stars 9 forks source link

Snapshot icons #34

Closed emiliopavia closed 4 years ago

emiliopavia commented 4 years ago

Checklist

Motivation and Context

With #28 we changed the semantic of GSJSensorSpec.rememberedAppearance. Now we're reverting back this change, handling it in a different way.

Description

After #28 we created an IconPath of type .proto, setting the sensor's identifier as the pathString. However this modification broke the original specification of GSJIconPath_PathType that says that pathString should be empty (and also some unit tests failed for this). In order to fix this we're using a different method to get the sensor icon that is not built in.