search

arduino / Arduino

Arduino IDE 1.x
https://www.arduino.cc/en/software
Other
14.08k stars 7.01k forks source link

Add Library to Library Manager #8262

Closed fhandy closed 5 years ago

fhandy commented 5 years ago

Dear Arduino Admin,

Please add this library to Library Manager

https://git.antares.id/lorawan-loraid/arduino-loraid

cmaglie commented 5 years ago

Done!

fhandy commented 5 years ago

thanks

Floessie commented 5 years ago

@Fhandy I was quickly browsing your lib and found LoRaIdClass::readData() curious. Not only is it documented as void read(void) (which is why I was looking into it), but it also takes a single pointer to be filled by the function. How can the caller know how big this buffer has to be without digging deeper? Better don't repeat the strcpy mess and add a size_t parameter and a public constexpr size_t MAX_OUT_BUF_SIZE = 64 or size_t getMaxOutputBufferSize() const.

Best, Flössie