search

arduino / Arduino

Arduino IDE 1.x
https://www.arduino.cc/en/software
Other
14.11k stars 7k forks source link

[Library Manager] Si4844 Library for Arduino #9304

Closed pu2clr closed 4 years ago

pu2clr commented 4 years ago

This is a library for the SI4844, BROADCAST ANALOG TUNING DIGITAL DISPLAY AM/FM/SW RADIO RECEIVER, IC from Silicon Labs for the Arduino development environment. This library is intended to provide an easier interface for controlling the SI4844.

Link GitHub: https://github.com/pu2clr/SI4844

per1234 commented 4 years ago

You need to create a release or tag that matches the version value in your library.properties file.

After doing so, please comment here to let us know we can proceed with adding your library to the Library Manager index.

For more information see: https://github.com/arduino/Arduino/wiki/Library-Manager-FAQ

pu2clr commented 4 years ago

Thanks for the answer. The release was created.

cmaglie commented 4 years ago

I've added the library to our indexer but there is a problem:

JOB 2512 - 2019/10/16 11:01:49 Scraping https://github.com/pu2clr/SI4844.git
JOB 2512 - 2019/10/16 11:02:23 Checking out tag: 1.0.1
JOB 2512 - 2019/10/16 11:02:23 Error syncing library: Error generating library from repo: Invalid character(s) found in major number "v1"

the release tag points to a library.properties that has the version field set to v1.0.1 while it should be 1.0.1: https://github.com/pu2clr/SI4844/blob/1.0.1/library.properties#L2

BTW I see that the master branch has this already fixed: https://github.com/pu2clr/SI4844/blob/master/library.properties#L2

so I to fix this you just I think you have to:

1) delete the tag/release 1.0.1 2) re-do the tag/release 1.0.1 on master

once done the library should be automatically published within an hour.

I'm closing the issue since no more actions are required on our side, please comment further if you have any problem.