mcspr commented 3 years ago

ref. https://github.com/esp8266/Arduino/pull/7939

Make sure comments are correct and make it clear to the user that these only return either true or false, and not a numeric value.

CLAassistant commented 3 years ago

All committers have signed the CLA.

codecov-commenter commented 3 years ago

Codecov Report

Merging #147 (a010db7) into master (e2d2f20) will not change coverage. The diff coverage is 95.55%.

@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   96.04%   96.04%           
=======================================
  Files          13       13           
  Lines         835      835           
=======================================
  Hits          802      802           
  Misses         33       33

Impacted Files	Coverage Δ
api/String.cpp	`97.69% <95.12%> (ø)`
api/String.h	`90.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e2d2f20...a010db7. Read the comment docs.

per1234 commented 3 years ago

It was rolled out to all ESP8266 users in that platform's 3.0.0 release 9 days ago and I haven't seen any reports of problems from them. But I'm also not super tuned in to the ESP8266 community.

facchinm commented 3 years ago

@aentinger I can't see any undesirable side effect since the usual promotion/demotion automatic rules apply, I'm ok for merging it :wink:

aentinger commented 3 years ago

Good to go then. Can't think of any undesirable side-effects myself.

arduino / ArduinoCore-API

Bool as return value for logical operations #147

Codecov Report