arduino / ArduinoCore-API

Hardware independent layer of the Arduino cores defining the official API

https://www.arduino.cc/reference/en/

GNU Lesser General Public License v2.1

216 stars 120 forks source link

Adding MacAddress, MacAddress8 #162

Open mrengineer7777 opened 2 years ago

mrengineer7777 commented 2 years ago

Adding New Classes MacAddress, MacAddress8 in the style of IPAddress. Note I didn't include Printable, as I don't understand how that works (edit: see updates below). If someone else wants to add it later, they are welcome to do so. This is my first time contributing to this repository, so please feel free to point out any mistakes.

This library originated on arduino-esp32 (https://github.com/espressif/arduino-esp32/pull/6667). It was suggested that I contribute to the Arduino core as well :)

CLAassistant commented 2 years ago

All committers have signed the CLA.

codecov-commenter commented 2 years ago

Codecov Report

Merging #162 (a740b1c) into master (e03b653) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #162   +/-   ##
=======================================
  Coverage   96.00%   96.00%           
=======================================
  Files          13       13           
  Lines         827      827           
=======================================
  Hits          794      794           
  Misses         33       33

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e03b653...a740b1c. Read the comment docs.

mrengineer7777 commented 2 years ago

Final version, ready for review. See test project here: https://github.com/mrengineer7777/MA_Test

mrengineer7777 commented 2 years ago

It seems there is no interest so I will be deleting this PR soon.

aentinger commented 2 years ago

Sorry, this fell through the cracks. In any case adding test code would be much appreciated.

@facchinm what do you think re integrating this to the core API?