search

arduino / ArduinoCore-API

Hardware independent layer of the Arduino cores defining the official API
https://www.arduino.cc/reference/en/
GNU Lesser General Public License v2.1
216 stars 120 forks source link

Fix volatile errors when compiling for C++23 #196

Closed jboynes closed 1 year ago

jboynes commented 1 year ago

C++20 deprecated the use of increment/decrement with volatile variables. This PR avoids the compiler warning at that language level or later.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (84b98c7) 95.77% compared to head (669bf38) 95.77%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #196 +/- ## ======================================= Coverage 95.77% 95.77% ======================================= Files 13 13 Lines 970 970 ======================================= Hits 929 929 Misses 41 41 ``` | [Files Changed](https://app.codecov.io/gh/arduino/ArduinoCore-API/pull/196?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arduino) | Coverage Δ | | |---|---|---| | [api/RingBuffer.h](https://app.codecov.io/gh/arduino/ArduinoCore-API/pull/196?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arduino#diff-YXBpL1JpbmdCdWZmZXIuaA==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

facchinm commented 1 year ago

Thanks for the fix! Merging