Fix compile rules for paths with spaces

arduino / ArduinoCore-arc32

GNU Lesser General Public License v2.1

329 stars 284 forks source link

Fix compile rules for paths with spaces #521

Closed facchinm closed 7 years ago

facchinm commented 7 years ago

The Java IDE applies specific transformations to the input "recipes" based on locale and OS. On Windows, if a path contains a space, the quotation marks get ignored and the whole commandline gets passed to the underlying GO program as a single string, leading to a failure when calling flag.Parse . Enclosing the whole flag+path instead than the path alone fixes the issue.

SidLeung commented 7 years ago

Will not use this PR in its entirety. However, will cherry-pick your change for the compile rules into the main trunk code and the Deneb.RC2 tag manually.

SidLeung commented 7 years ago

Changes were cherry-picked and merged to main trunk (#522). Thus, closing this PR.