arduino / ArduinoCore-avr

The Official Arduino AVR core
https://www.arduino.cc
1.22k stars 1.04k forks source link

"PE" Redifined error with ATmega8 and gcc 4.5.3 [imported] #226

Closed cmaglie closed 4 years ago

cmaglie commented 11 years ago

This is Issue 618 moved from a Google Code project. Added by 2011-09-01T13:50:50.000Z by arkali...@gmail.com. Please review that bug for more context and additional comments, but update this bug.

Original labels: Type-Defect, Priority-Medium

Original description

What steps will reproduce the problem?

Building with gcc 4.5.3 for ATmega8 the "PE" is redefined in pins_arduino.c line 72. The previous declaration is in file iom8.h in line 516, is the PE bit of UCSRA. With ATmega328 where is no problem as the PE bit is renamed. An easy solution is to move PE, PF, PG, PH, PJ, PK, and PL definitions from lines 72-78 in pins_arduino.c to line 82, inside the ATmega1280 block, as these ports exist only in arduino mega boads.

What version of the Arduino software are you using? On what operating system? Which Arduino board are you using?

I am using 1.0beta2 with arduino-uno under debian-linux.

Please provide any additional information below.

per1234 commented 7 years ago

Still exists in Arduino AVR Boards 1.6.19 but it's a warning, not an error and the definition is now in Arduino.h: https://github.com/arduino/Arduino/blob/1.8.3/hardware/arduino/avr/cores/arduino/Arduino.h#L195

Related (but not duplicate) issue: https://github.com/arduino/Arduino/issues/4620

facchinm commented 4 years ago

Keeping track on #148