search

arduino / ArduinoCore-avr

The Official Arduino AVR core
https://www.arduino.cc
1.25k stars 1.06k forks source link

CDC.cpp is unused #398

Closed teliot closed 3 years ago

teliot commented 3 years ago

The file cores/arduino/CDC.cpp is never used in the current tree. It appears that the CDC endpoint is now created in USBApi, USBCore, and USBDesc.

Should the serial port be unavailable without Serial.begin()? This would have the drawback of forcing the user to press the restart button on a 32u4 based device to manually upload a sketch.

teliot commented 3 years ago

Sorry was wrong, it has some extern code that is being used. But the CDC.cpp file never has an include in the tree and I see that most of its code was copied out.

Will cleanup before re-submitting issue.