Open bridystone opened 3 years ago
I just ran into this issue in a personal project. Would love to see this PR merged!
coding style question - it looks a bit dangerous to use return;
just to get out of the switch-case early.
I think that break;
would also work in this case - it's more "future-safe", and generally better style (single exit for the function).
coding style question - it looks a bit dangerous to use
return;
just to get out of the switch-case early. I think thatbreak;
would also work in this case - it's more "future-safe", and generally better style (single exit for the function).
This is absolutely correct. I can not see, why I used return. There is no point in doing so....
Memory usage change @ dfb2462101be632b8a45d995fcfa90e2beb0bff0
Board | flash | % | RAM for global variables | % |
---|---|---|---|---|
arduino:megaavr:nona4809 | :small_red_triangle: 0 - +52 | 0.0 - +0.11 | 0 - 0 | 0.0 - 0.0 |
arduino:megaavr:uno2018:mode=off | :small_red_triangle: +8 - +48 | +0.02 - +0.1 | 0 - 0 | 0.0 - 0.0 |
arduino:megaavr:uno2018:mode=on | :small_red_triangle: +8 - +48 | +0.02 - +0.1 | 0 - 0 | 0.0 - 0.0 |
1st proposal to adjust turnOffPWM to prevent interfering with timers, if the DigitalWrite is using default pins. #75