Closed aentinger closed 3 years ago
Memory usage change @ 87fc54bc1b2f41c5474ca1ff2644d698c35163aa
Board | flash | % | RAM for global variables | % |
---|---|---|---|---|
arduino:megaavr:nona4809 | 0 - 0 | 0.0 - 0.0 | 0 - 0 | 0.0 - 0.0 |
arduino:megaavr:uno2018:mode=off | 0 - 0 | 0.0 - 0.0 | 0 - 0 | 0.0 - 0.0 |
arduino:megaavr:uno2018:mode=on | 0 - 0 | 0.0 - 0.0 | 0 - 0 | 0.0 - 0.0 |
Changing return type of
requestFrom
fromuint8_t
tosize_t
allows the function to return the correct amount of bytes read (since internally it's already asize_t
which is downcast to auint8_t
upon returning it).Merging this PR is a pre-condition for merging https://github.com/arduino/ArduinoCore-API/pull/132.
@facchinm Let's coordinate to get this done.