arduino / ArduinoCore-samd

Arduino Core for SAMD21 CPU
GNU Lesser General Public License v2.1
467 stars 714 forks source link

dpinst-amd64.exe is not signed for Windows 10 #496

Open don opened 4 years ago

don commented 4 years ago

dpinst-amd64.exe is not signed (or the signature has expired)

Steps to duplicate

IMG_6591

Users can work around this by saying yes, but it's not OK to expect users to ignore this warning. Signed drivers are really important for avoiding malware. Arduino software installs shouldn't be encouraging people, especially beginners, to bypass security restrictions.

Suggested resolution: replace dpinst-amd64.exe with an updated version that has a valid signature.

cmaglie commented 4 years ago

AFAIK those are the same dpinst coming directly from Microsoft... By the way I'll try to create a signed version of those to try it out.

don commented 4 years ago

@cmaglie I’m still seeing with Arduino 1.8.13 and SAMD 1.8.8 on a new Windows 10 machine. Can you revisit getting a newer signed version of dpinst-amd64.exe into the Arduino installer? The latest Windows Driver Kit (WDK) should have a newer signed version of the exe. Thanks!

nahshonw commented 1 year ago

12 Sept 2022 and I had to google this issue on Windows 10. Arduino is a big enough name to have signed drivers. I feel violated for saying yes on this clean install. Please just fix it.

dlimabean commented 1 year ago

Still a problem on Nov 26 2022

dlimabean commented 1 year ago

Are we confident with the distributors of arduino to ignore this problem?

cmaglie commented 1 year ago

Finding where dpinst.exe is placed in the Microsoft Developer Kit is an epic quest on his own.

I've installed the latest WDK for Windows 11, but can't find dpinst.exe anywhere.

After an hour of google search, I finally learned that it is part of the Driver Install Framework (DIFx) https://learn.microsoft.com/en-us/windows-hardware/drivers/install/difx-guidelines and it seems to be deprecated:

Starting in Windows 10 Version 1607 (Redstone 1), the Driver Install Frameworks (DIFx) tools (Difxapi.dll, Difxapp.dll, Difxappa.dll, and DPInst.exe) are deprecated and are no longer included in the WDK.

So to find the latest available version of dpinst.exe we should look inside a WDK for Windows < 10 v1607. The bigger version available is the Microsoft WDK 8.0 (since the WDK 8.1 seems to have been removed from the download page https://learn.microsoft.com/en-us/windows-hardware/drivers/other-wdk-downloads#step-2-install-the-wdk).

I will save you the pain to install and find dpinst.exe inside the WDK 8.0: the file is installed in C:/Program Files (x86)/Windows Kits/8.0/redist/DIFx/dpinst/MultiLin/x64/dpinst.exe.

Here is the file: dpinst.zip and AFAIC the file is not signed.

At this point I'm not sure what's the best way forward...

cmaglie commented 1 year ago

PnPUtil may be an alternative to dpinst: https://learn.microsoft.com/en-us/windows-hardware/drivers/devtest/pnputil

cmaglie commented 1 year ago

I've investigated the use of pnputil.exe, it's very similar to dpinst, it has basically the same features, but it won't prompt the user to gain admin privileges (the so-called UAC prompt, shown in @don's screenshot).

C:\Users\cmagl\Code\ArduinoCore-samd>pnputil /add-driver drivers\arduino-samd.inf /install
Utilità Plug and Play Microsoft

Aggiunta del pacchetto driver in corso:  arduino-samd.inf
Non è possibile aggiungere il pacchetto driver: Accesso negato.        <----- this means "Access denied."

Pacchetti driver totali:  1
Pacchetti driver aggiunti:  0

C:\Users\cmagl\Code\ArduinoCore-samd>

So we cannot use pnputil because the post-install.bat script is run as a non-privileged user by the Arduino IDE.

cmaglie commented 1 year ago

Another interesting fact is that the dpinst.exe distributed with the packages are actually signed by Microsoft:

Image

This means that the UAC dialog is displayed because the driver installation requires administrator privileges (and not because the dpinse.exe is not signed).

There is no way to avoid that. Even if you try to run Arduino IDE as admin, to begin with, this will trigger another UAC asking the user if it's ok to run the IDE as admin.

umbynos commented 1 year ago

After this tentative, it seems clear that this is an approach that we cannot follow. Another way of doing this would be to develop our tool that visualize the UAC and launches itself either pnputil or dpinst once it has the privileges.

Sajons commented 1 year ago

Hello everyone, i have install arduino now on my PC and while the installation was running, the message "dpinst-amd64.exe" came. I clicked "No". Now I have read out that this .exe would be important. How do I install this later?

per1234 commented 1 year ago

Hi @Sajons. Please post your question to the Arduino Forum:

https://forum.arduino.cc/c/using-arduino/installation-troubleshooting/18

I'll be happy to help you over there.

william-vh commented 9 months ago

Arduino Version 1.8.19. Still an issue. Safe?

PeterGribbin commented 7 months ago

This issue also affects Arduino IDE 2.2.1. It prevents me using the Arduino nano esp32 on work computers for which I do not have admin credentials.