search

arduino / ArduinoCore-samd

Arduino Core for SAMD21 CPU
GNU Lesser General Public License v2.1
467 stars 715 forks source link

Serial buffer size unchangeable #700

Open maxgerhardt opened 1 year ago

maxgerhardt commented 1 year ago

Per https://github.com/arduino/ArduinoCore-samd/pull/651#issuecomment-1492773652.

Due to the #undef construct done in

https://github.com/arduino/ArduinoCore-samd/blob/a5d52dbf7bcf338de2042eb74cfba33993729c81/cores/arduino/Uart.h#L25-L29

it's not possible to set a global -DSERIAL_BUFFER_SIZE=... value and have it be use used anymore.

A user has a usecase for that here.

Muny commented 1 year ago

Agreed, it was pretty deleterious to add those.

maxgerhardt commented 1 year ago

Still seems like the amount of people that care about this is exactly 0.

Muny commented 1 year ago

Still seems like the amount of people that care about this is exactly 0.

I presume it's because the people who do care about it find ways to work around it. I ended up adding a pre-build step to my project to patch this file.