Replace JS espace(...) call with encodeURIComponent(...)

arduino / WiFi101-FirmwareUpdater-Plugin

WiFi101 Firmware Updater Tool for Arduino IDE

13 stars 23 forks source link

Closed sandeepmistry closed 5 years ago

sandeepmistry commented 5 years ago

escape(...) was used in the custom provisioning HTML page, this change uses encodeURIComponent(...) instead. See: https://alanristic.wordpress.com/2013/02/16/javascript-escape-vs-encodeuri-vs-encodeuricomponent/

cc/ @tigoe

Rocketct commented 5 years ago

Tested, with an AP with the password Arduinocc_+1 and the results was the following:

19.6.1: provisioning works properly;
19.5.4: provisioning works properly;
19.5.2: provisioning works properly, but the serial monitor not show the print, but the board connect to the AP, and send the value to the web page;
19.4.4: not works with sign, works only with character, the issue is still there(double checked).

tigoe commented 5 years ago

I tested at home with the password that failed me last time, and it's working great, thank you.